mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.
Date Tue, 05 Jul 2016 08:58:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46825/
-----------------------------------------------------------

(Updated July 5, 2016, 10:58 a.m.)


Review request for mesos, Alexander Rukletsov and Vinod Kone.


Changes
-------

Also updated documentation.


Bugs: MESOS-3335
    https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
-------

Fully-typed all FlagsBase::add overloads.


Diffs (updated)
-----

  3rdparty/stout/include/stout/flags.hpp 169f959ab2770744d615cc235062ba2becc8af64 
  3rdparty/stout/include/stout/flags/flags.hpp dd9362772d1fbd32638fc7e70126fd49d4a03c68 
  3rdparty/stout/tests/flags_tests.cpp 77f3a6af110da1ffcdf2b7ab2b66431a6b5c91d3 
  3rdparty/stout/tests/subcommand_tests.cpp 9213d6b9faec30b5be320ab37ca29c2406c964ac 

Diff: https://reviews.apache.org/r/46825/diff/


Testing
-------

make check (OS X clang-trunk w/o optimizations)

The mesos tests suite do not execute at all with an optimizing clang-trunk since copying of
the `map` inside `FlagsBase` reference random memory leading to `SEGFAULTs`. With these patches
all of `stout-tests` and `libprocess-tests` can be executed, but some remaining failures persist
in `mesos-tests` (their number is reduced though).


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message