mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.
Date Tue, 05 Jul 2016 08:09:01 GMT


> On May 11, 2016, 11:38 p.m., Vinod Kone wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, lines 147-179
> > <https://reviews.apache.org/r/46825/diff/1/?file=1365696#file1365696line147>
> >
> >     do we even need these overloads anymore? can't we just use the below overloads
that use 'Flags' as a template parameter?

Make perfect sense, removed them.


> On May 11, 2016, 11:38 p.m., Vinod Kone wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, lines 181-189
> > <https://reviews.apache.org/r/46825/diff/1/?file=1365696#file1365696line181>
> >
> >     why did you move this overload? makes is really hard to understand what changed.
:(

This overload needs to be accessible to users so I made it `public`.


> On May 11, 2016, 11:38 p.m., Vinod Kone wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, lines 289-290
> > <https://reviews.apache.org/r/46825/diff/1/?file=1365696#file1365696line289>
> >
> >     this comment needs to be updated.

The overload this comment refers to was removed with all the other overloads not taking pointers
to members. I also removed the comment in that change.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46825/#review132753
-----------------------------------------------------------


On July 5, 2016, 1:13 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46825/
> -----------------------------------------------------------
> 
> (Updated July 5, 2016, 1:13 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Bugs: MESOS-3335
>     https://issues.apache.org/jira/browse/MESOS-3335
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fully-typed all FlagsBase::add overloads.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/flags/flags.hpp dd9362772d1fbd32638fc7e70126fd49d4a03c68

>   3rdparty/stout/tests/flags_tests.cpp 77f3a6af110da1ffcdf2b7ab2b66431a6b5c91d3 
>   3rdparty/stout/tests/subcommand_tests.cpp 9213d6b9faec30b5be320ab37ca29c2406c964ac

> 
> Diff: https://reviews.apache.org/r/46825/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X clang-trunk w/o optimizations)
> 
> The mesos tests suite do not execute at all with an optimizing clang-trunk since copying
of the `map` inside `FlagsBase` reference random memory leading to `SEGFAULTs`. With these
patches all of `stout-tests` and `libprocess-tests` can be executed, but some remaining failures
persist in `mesos-tests` (their number is reduced though).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message