mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 49600: Added authz to /files/debug endpoint.
Date Tue, 05 Jul 2016 07:03:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49600/#review140726
-----------------------------------------------------------




src/files/files.cpp (lines 726 - 728)
<https://reviews.apache.org/r/49600/#comment206076>

    The lambda doesn't use any method nor attribute from `FilesProcess`, so you can save the
`defer()` call as well as the `this` capture.



src/files/files.cpp (line 728)
<https://reviews.apache.org/r/49600/#comment206077>

    `request` is possible a big object and you will be using just on field of the `url.query`
attribute. Why not copying that value and capturing only that one?
    
    I also wonder if one can save itself from copying a possible big `object` object.


- Alexander Rojas


On July 4, 2016, 7:41 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49600/
> -----------------------------------------------------------
> 
> (Updated July 4, 2016, 7:41 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Alexander Rojas, and Jan Schlicht.
> 
> 
> Bugs: MESOS-5369
>     https://issues.apache.org/jira/browse/MESOS-5369
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added authz to /files/debug endpoint.
> 
> 
> Diffs
> -----
> 
>   src/common/http.cpp fffa24cb07f73dd2bc8edc59fc276fdca5b86380 
>   src/files/files.hpp b767d5bc5bee16e3bd98199773a6bc7d30c1c32d 
>   src/files/files.cpp a5a1b86e14f63e5e3834a2900270252fbe16f586 
>   src/master/main.cpp 84f3b0723fd3df02386c8072ded3cb42272cd065 
>   src/slave/main.cpp a7ed669a0b6861d6ce8546dfafac849044a77eec 
>   src/tests/files_tests.cpp 31337e280c6224a8c949c8868a53e5a785b4573f 
> 
> Diff: https://reviews.apache.org/r/49600/diff/
> 
> 
> Testing
> -------
> 
> On Ubuntu 16.04:
> 
> sudo GTEST_FILTER="FilesTest.DebugTest" make -j4 check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message