-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49615/#review140716
-----------------------------------------------------------
Patch looks great!
Reviews applied: [49598, 49615]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On July 4, 2016, 10:09 p.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49615/
> -----------------------------------------------------------
>
> (Updated July 4, 2016, 10:09 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-5401
> https://issues.apache.org/jira/browse/MESOS-5401
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We use the the `com.nvidia.volumes.needed` label from
> nvidia-docker to decide if we should inject the volume or not:
>
> https://github.com/NVIDIA/nvidia-docker/wiki/Image-inspection
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/gpu/volume.cpp 9aac3cc8622c21014de87576f84180d30ae3fadd
> src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 474040c89d69b50c051122d873c11a102b33c538
>
> Diff: https://reviews.apache.org/r/49615/diff/
>
>
> Testing
> -------
>
> `GTEST_FILTER="" make -j check && GTEST_FILTER="*NVIDIA_GPU_VolumeShouldInject"
bin/mesos-tests.sh`
>
>
> Thanks,
>
> Kevin Klues
>
>
|