-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49612/#review140713
-----------------------------------------------------------
Patch looks great!
Reviews applied: [49610, 49612]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On July 4, 2016, 8:40 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49612/
> -----------------------------------------------------------
>
> (Updated July 4, 2016, 8:40 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If a test case calls `Clock::settle` and then immediately waits for a
> future to be completed, settling the clock is usually unnecessary.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp 0498cd5e54b0e4b87a767585a77699653aa52179
>
> Diff: https://reviews.apache.org/r/49612/diff/
>
>
> Testing
> -------
>
> `mesos-tests --gtest_filter=HierarchicalAllocatorTest.* --gtest_repeat=500 --gtest_break_on_failure`
>
>
> Thanks,
>
> Neil Conway
>
>
|