mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 49604: Fixed incorrect clock time in log messages.
Date Tue, 05 Jul 2016 00:00:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49604/#review140709
-----------------------------------------------------------



Patch looks great!

Reviews applied: [49602, 49604]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On July 4, 2016, 6:21 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49604/
> -----------------------------------------------------------
> 
> (Updated July 4, 2016, 6:21 p.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previous code included a pointer value in a log message, rather
> than the clock time that the pointer points at.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/clock.cpp 3fd616e91c9b8c2ac2d14a49714d340ba5a3a5da 
> 
> Diff: https://reviews.apache.org/r/49604/diff/
> 
> 
> Testing
> -------
> 
> Previous log output:
> 
> ```
> I0704 20:15:47.270100 1970868224 clock.cpp:329] Clock paused at 0x7ff72842d310
> ```
> 
> Revised log output:
> 
> ```
> I0704 20:17:59.394853 1970868224 clock.cpp:329] Clock paused at 2016-07-04 18:17:59.394846976+00:00
> ```
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message