mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 49610: Added test case for quota allocation with reserved resources.
Date Mon, 04 Jul 2016 23:29:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49610/#review140704
-----------------------------------------------------------




src/tests/hierarchical_allocator_tests.cpp (line 3192)
<https://reviews.apache.org/r/49610/#comment206051>

    Can you please move this case right before `HierarchicalAllocatorTest, DeactivateAndReactivateFramework`
to group all `quota` related test case?



src/tests/hierarchical_allocator_tests.cpp (lines 3208 - 3218)
<https://reviews.apache.org/r/49610/#comment206053>

    Does there are any special reason that you are using `dynamic reservation` here? Seems
using `static reservation` may be more simple as your test is against allocation but not dynamic
reservation.


- Guangya Liu


On 七月 4, 2016, 8:39 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49610/
> -----------------------------------------------------------
> 
> (Updated 七月 4, 2016, 8:39 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test checks that when setting aside unallocated resources to ensure
> that a quota guarantee can be met, we don't use resources that have been
> reserved for a different role.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp 0498cd5e54b0e4b87a767585a77699653aa52179

> 
> Diff: https://reviews.apache.org/r/49610/diff/
> 
> 
> Testing
> -------
> 
> `./src/mesos-tests --gtest_filter="HierarchicalAllocatorTest.QuotaSetAsideReservedResources"
--gtest_repeat=100 --gtest_break_on_failure` passes. When you apply a patch that breaks quota
allocation behavior (https://gist.github.com/neilconway/97eed34e9b0b312b8511f0f4f57fe061),
previously `make check` passes, but it fails with this new test added.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message