mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Review Request 49615: Implemented 'shouldInject()' in the 'NvidiaVolume' component.
Date Mon, 04 Jul 2016 22:09:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49615/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-5401
    https://issues.apache.org/jira/browse/MESOS-5401


Repository: mesos


Description
-------

We use the the `com.nvidia.volumes.needed` label from
nvidia-docker to decide if we should inject the volume or not:

https://github.com/NVIDIA/nvidia-docker/wiki/Image-inspection


Diffs
-----

  src/slave/containerizer/mesos/isolators/gpu/volume.cpp 9aac3cc8622c21014de87576f84180d30ae3fadd

  src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 474040c89d69b50c051122d873c11a102b33c538


Diff: https://reviews.apache.org/r/49615/diff/


Testing
-------

`GTEST_FILTER="" make -j check && GTEST_FILTER="*NVIDIA_GPU_VolumeShouldInject" bin/mesos-tests.sh`


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message