mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Review Request 49612: Removed unnecessary `Clock::settle` calls from test cases.
Date Mon, 04 Jul 2016 20:40:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49612/
-----------------------------------------------------------

Review request for mesos and Alexander Rukletsov.


Repository: mesos


Description
-------

If a test case calls `Clock::settle` and then immediately waits for a
future to be completed, settling the clock is usually unnecessary.


Diffs
-----

  src/tests/hierarchical_allocator_tests.cpp 0498cd5e54b0e4b87a767585a77699653aa52179 

Diff: https://reviews.apache.org/r/49612/diff/


Testing
-------

`mesos-tests --gtest_filter=HierarchicalAllocatorTest.* --gtest_repeat=500 --gtest_break_on_failure`


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message