> On June 25, 2016, 8:42 p.m., Guangya Liu wrote:
> > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp, line 429
> > <https://reviews.apache.org/r/49184/diff/2/?file=1429865#file1429865line429>
> >
> > Just nit: What about adding a comment here, someone may be confused as when
they saw that you only handled `file volume` for container with rootfs but not for containers
without rootfs.
> >
> > // The container path can be either a directory or a
> > // file. If the conainer path is a file here, the file
> > // will be mounted as a volume to the container as well.
>
> Gilbert Song wrote:
> Thanks! I will address it.
I decided to move this comment above since it is for all cases.
- Gilbert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49184/#review139473
-----------------------------------------------------------
On July 4, 2016, 10:40 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49184/
> -----------------------------------------------------------
>
> (Updated July 4, 2016, 10:40 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Jie Yu, Timothy Chen, and Jiang Yan Xu.
>
>
> Bugs: MESOS-5697
> https://issues.apache.org/jira/browse/MESOS-5697
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented file volume support in mesos containerizer.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/filesystem/linux.cpp adacde191132a7a92c1fdf27ef8a4a41d2afa003
>
> Diff: https://reviews.apache.org/r/49184/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
|