mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 49184: Implemented file volume support in mesos containerizer.
Date Mon, 04 Jul 2016 17:14:41 GMT


> On June 25, 2016, 8:42 p.m., Guangya Liu wrote:
> > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp, line 429
> > <https://reviews.apache.org/r/49184/diff/2/?file=1429865#file1429865line429>
> >
> >     Just nit: What about adding a comment here, someone may be confused as when
they saw that you only handled `file volume` for container with rootfs but not for containers
without rootfs.
> >     
> >     // The container path can be either a directory or a
> >     // file. If the conainer path is a file here, the file
> >     // will be mounted as a volume to the container as well.

Thanks! I will address it.


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49184/#review139473
-----------------------------------------------------------


On June 24, 2016, 12:19 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49184/
> -----------------------------------------------------------
> 
> (Updated June 24, 2016, 12:19 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, Timothy Chen, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5697
>     https://issues.apache.org/jira/browse/MESOS-5697
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented file volume support in mesos containerizer.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp adacde191132a7a92c1fdf27ef8a4a41d2afa003

> 
> Diff: https://reviews.apache.org/r/49184/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message