mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 49568: Simplified a flag in the launch helper binary.
Date Mon, 04 Jul 2016 16:37:48 GMT


> On July 4, 2016, 8:09 a.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, line 1179
> > <https://reviews.apache.org/r/49568/diff/1/?file=1435796#file1435796line1179>
> >
> >     Actually I really dont like `commands` in isolator.proto `ContainerLaunchInfo`.
Good to consider a deprecation cycle to change it to `pre_exec_commands`.

This is internal to Mesos so I don't think we need a deprecation cycle (we can just change
the name without changing the tag number).


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49568/#review140622
-----------------------------------------------------------


On July 3, 2016, 5:50 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49568/
> -----------------------------------------------------------
> 
> (Updated July 3, 2016, 5:50 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Ian Downes.
> 
> 
> Bugs: MESOS-5753
>     https://issues.apache.org/jira/browse/MESOS-5753
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Using JSON::Object is not necessary. Also, the current name is quite
> confusing as we have another flag called '--command'. This patch
> simplified this flag.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp a96b382f22886362a1159e1166dfe041072985ba

>   src/slave/containerizer/mesos/launch.hpp c716e0396736d1f2f60ec31540f12f4f7597d081 
>   src/slave/containerizer/mesos/launch.cpp 83f4d7f28c066a605aa84862eca9fde900ec96c6 
> 
> Diff: https://reviews.apache.org/r/49568/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message