mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 49424: Added an abstraction os::raw::Argv in stout.
Date Mon, 04 Jul 2016 16:22:06 GMT


> On July 2, 2016, 5:11 p.m., Joris Van Remoortere wrote:
> > 3rdparty/stout/include/stout/os/raw/argv.hpp, line 40
> > <https://reviews.apache.org/r/49424/diff/2/?file=1434264#file1434264line40>
> >
> >     It seems like this extra vector and the subsequent copy into the argv array
is only necessary because you're supporting structures with an unknown size.
> >     
> >     Would this be simpler if you restricted to inputs that support `.size()`?

Yes, it would be simpler, but I still have to deal with issues like size() of protobuf repeated
field returns an int while other std containers return size_t (unsigned). This is just pointer
copies so it won't be too bad.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49424/#review140451
-----------------------------------------------------------


On June 30, 2016, 4:18 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49424/
> -----------------------------------------------------------
> 
> (Updated June 30, 2016, 4:18 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added an abstraction os::raw::Argv in stout.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/Makefile.am f10c836c1ac008cc4055741648b5e7dd697e4c1e 
>   3rdparty/stout/include/stout/os.hpp 53b00932693fba7cf6514da6a519269a904de345 
>   3rdparty/stout/include/stout/os/raw/argv.hpp PRE-CREATION 
>   3rdparty/stout/tests/os_tests.cpp 786da14addf62be5f5270f156fb1e011d3f403e3 
> 
> Diff: https://reviews.apache.org/r/49424/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message