mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <>
Subject Re: Review Request 49400: Extended utilities to render certificate extension for IP.
Date Mon, 04 Jul 2016 16:17:26 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 4, 2016, 4:17 p.m.)

Review request for mesos, Adam B, Albert Strasheim, Artem Harutyunyan, Joris Van Remoortere,
and Lukas Loesche.


Removed pointless "struct" reference and fixed a possible leak.

Bugs: MESOS-5724

Repository: mesos


Adds the ability to render a subject alternative name based on a given
IP address within a X509 certificate extension. Additionally the
libprocess test suite makes use of this feature.

Diffs (updated)

  3rdparty/libprocess/include/process/ssl/gtest.hpp 5435ddda1fd7dfcff1a0b28f2abe35feb707ceeb

  3rdparty/libprocess/include/process/ssl/utilities.hpp ad9ec5df9d3c3e46c775ac470bce92c5cb983b8f

  3rdparty/libprocess/src/ssl/utilities.cpp 02bfd1798c6037c88229bb0da33a614d4c598550 



make check on OSX and various linux distros.

Functional testing by validating a rendered certificate;

openssl x509 -text -noout -in "temp_cert_file_name"


Till Toenshoff

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message