> On July 1, 2016, 9:33 p.m., Gilbert Song wrote:
> > Do you miss `windows/executor.hpp`?
>
> Gilbert Song wrote:
> Fix it, Ship it! :)
Thanks! Fixed it.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49415/#review140433
-----------------------------------------------------------
On June 30, 2016, 12:54 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49415/
> -----------------------------------------------------------
>
> (Updated June 30, 2016, 12:54 a.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> It's confusing to pass in 'argv' because it's already contained in
> 'command'. This patch removed this parameter.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp bb88a4570d183d22dff65f6e220d566c0924001a
> src/launcher/posix/executor.hpp e5f3c0a8e2d3687a5330adbf2f667db9106970c7
> src/launcher/posix/executor.cpp ab1dd938a7c59f52b44aafe1340c614087460f84
> src/launcher/windows/executor.cpp f6da398eeddaf68b8eaf510648c55964d9f5b7c7
>
> Diff: https://reviews.apache.org/r/49415/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
|