mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 49262: Added '--enable-netlink' into configure.ac.
Date Mon, 04 Jul 2016 14:25:18 GMT


> On June 28, 2016, 4:41 a.m., Jie Yu wrote:
> > configure.ac, lines 2087-2088
> > <https://reviews.apache.org/r/49262/diff/1/?file=1431041#file1431041line2087>
> >
> >     Instead of copying it, can you place this check first and the `with_network_isolator`
check can be simplified to check `enable_netlink` plus some additional functions that's needed
by network port mapping isolator?
> >     
> >     I think `nl_has_capability` was introduced in 3.2.25 or something, and only
network port mapping isolator has this restriction. For getting stats, I don't think we need
libnl 3.2.26 or higher.
> >     
> >     Ideally, enable_netlink only requires the default libnl3 on ubuntu/centos (which
is 3.2.21 I believe).

> Instead of copying it, can you place this check first and the with_network_isolator check
can be simplified to check enable_netlink plus some additional functions that's needed by
network port mapping isolator?

I had the same concern when I copied it. However I think `--enable-netlink` and `--with-network-isolator`
are two separate options, that means user is free to specifiy both of them or either of them,
so what about user only specifies `--with-network-isolator` but not `--enable-netlink`? If
we want to avoid the copying, maybe we should make `--with-network-isolator` depend on `--enable-netlink`,
i.e., `--with-network-isolator` only work when `--enable-netlink` is also specified, just
like the relationship between `--enable-ssl` and `--enable-libevent`: if user only specifes
`--enable-ssl` but not `--enable-libevent`, the `configure` script will fail with an error
message `"SSL is currently only supported with libevent"`.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49262/#review139647
-----------------------------------------------------------


On June 27, 2016, 9:03 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49262/
> -----------------------------------------------------------
> 
> (Updated June 27, 2016, 9:03 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Jie Yu.
> 
> 
> Bugs: MESOS-5646
>     https://issues.apache.org/jira/browse/MESOS-5646
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added '--enable-netlink' into configure.ac.
> 
> 
> Diffs
> -----
> 
>   configure.ac 321436beb8ad87bb5727932eb2943986fe558237 
> 
> Diff: https://reviews.apache.org/r/49262/diff/
> 
> 
> Testing
> -------
> 
> After running `bootstrap` script, the newly introduced flag `"--enable-netlink"` will
appear in the `configure` script:
> 
> ```
> $ ../configure --help 
> `configure' configures mesos 1.0.0 to adapt to many kinds of systems.
>   ...
>   --enable-netlink        enable netlink for transferring miscellaneous
>                           networking information between the kernel space and
>                           userspace processes default: no
>   ...
> ```
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message