mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <>
Subject Re: Review Request 46823: Fully qualified addresses of Flag members in add calls in stout.
Date Mon, 04 Jul 2016 12:41:44 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 4, 2016, 2:41 p.m.)

Review request for mesos, Alexander Rukletsov and Vinod Kone.

Bugs: MESOS-3335

Repository: mesos


While right now we can technically `add` variables to `Flags` classes
which are not members, the in order to have correct copy semantics for
`Flags` only member variables should be used.

Here we changed all instances to a full pointer-to-member syntax in
the current code.

Diffs (updated)

  3rdparty/libprocess/src/tests/subprocess_tests.cpp 3f3e21514bd5e2e388165eb64d540764097557ac



Tested on various platforms in internal CI.


Benjamin Bannier

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message