mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 49223: Enhance value parsing.
Date Mon, 04 Jul 2016 11:55:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49223/#review140648
-----------------------------------------------------------




src/common/values.cpp (line 648)
<https://reviews.apache.org/r/49223/#comment206024>

    Can you please show more detail for what do you want check here in the comment? Do you
mean you want to validate the `token` here?



src/common/values.cpp (line 665)
<https://reviews.apache.org/r/49223/#comment206025>

    Sorry, I should ask this question in previous patch. Same as above, can you please show
more comments for what do you want to check here? It would be great if you can make the comment
easy to understand.


- Guangya Liu


On 七月 4, 2016, 10:33 a.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49223/
> -----------------------------------------------------------
> 
> (Updated 七月 4, 2016, 10:33 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5739
>     https://issues.apache.org/jira/browse/MESOS-5739
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enhance value parsing.
> 
> 
> Diffs
> -----
> 
>   src/common/values.cpp 587cb68551d438621e215953e89818b623b7f71b 
>   src/tests/values_tests.cpp 929861549e3155c33966896f817f9bf9e6d14354 
> 
> Diff: https://reviews.apache.org/r/49223/diff/
> 
> 
> Testing
> -------
> 
> make && make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message