mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joerg Schad <>
Subject Re: Review Request 49369: Introduced authorization based filtering for /roles.
Date Mon, 04 Jul 2016 09:12:27 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 4, 2016, 9:12 a.m.)

Review request for mesos, Adam B and Vinod Kone.



Bugs: MESOS-5709

Repository: mesos


Previously only /weights was filtered but /roles actually
contains the same information and hence both endpoints
should be filtered in the same way.
As part of this work we renamed the GetWeight action to
ViewRole (and same for the acls).

Diffs (updated)

  include/mesos/authorizer/acls.proto 31d5c144f92749d685dbf75b65362bd633c54ea5 
  include/mesos/authorizer/authorizer.proto e22d3a491e0c5e7c384af8635a7f555e2194b939 
  src/authorizer/local/authorizer.cpp e5d4addd0b6d0323144c9b28c0fb46331f5d4dc1 
  src/common/http.hpp c410d039d6e832e0f838591b06f5d6a5d1f4197d 
  src/common/http.cpp fffa24cb07f73dd2bc8edc59fc276fdca5b86380 
  src/master/http.cpp 7b2f77b9264242f31ab62eb9db7c621a1b8aa2fe 
  src/master/weights_handler.cpp 5fc69c6a1c2663bad1774d9376b0aa9f90fa7275 
  src/tests/authorization_tests.cpp ddd1f6f8caff7b78746f7344c83b89305e94e203 
  src/tests/dynamic_weights_tests.cpp c67ed75a050b9db5575ac2bb6100bcf01cfc04ff 
  src/tests/master_authorization_tests.cpp 0807469763b14f39b594769341d5eb9678d26946 



sudo make check


Joerg Schad

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message