mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 49568: Simplified a flag in the launch helper binary.
Date Mon, 04 Jul 2016 08:09:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49568/#review140622
-----------------------------------------------------------


Ship it!




LGTM!


src/slave/containerizer/mesos/containerizer.cpp (line 1179)
<https://reviews.apache.org/r/49568/#comment206004>

    Actually I really dont like `commands` in isolator.proto `ContainerLaunchInfo`. Good to
consider a deprecation cycle to change it to `pre_exec_commands`.


- Gilbert Song


On July 2, 2016, 10:50 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49568/
> -----------------------------------------------------------
> 
> (Updated July 2, 2016, 10:50 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Ian Downes.
> 
> 
> Bugs: MESOS-5753
>     https://issues.apache.org/jira/browse/MESOS-5753
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Using JSON::Object is not necessary. Also, the current name is quite
> confusing as we have another flag called '--command'. This patch
> simplified this flag.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp a96b382f22886362a1159e1166dfe041072985ba

>   src/slave/containerizer/mesos/launch.hpp c716e0396736d1f2f60ec31540f12f4f7597d081 
>   src/slave/containerizer/mesos/launch.cpp 83f4d7f28c066a605aa84862eca9fde900ec96c6 
> 
> Diff: https://reviews.apache.org/r/49568/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message