mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 49540: Used the argv version for command that launches the command executor.
Date Mon, 04 Jul 2016 05:59:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49540/#review140608
-----------------------------------------------------------




src/slave/slave.cpp (line 3956)
<https://reviews.apache.org/r/49540/#comment205993>

    Could you explain why we change the behavior here?
    
    Old:
    Only command task with rootfs has shell as false.
    
    Now:
    Command task with/without rootfs will defaultly have shell as false.



src/slave/slave.cpp (line 3958)
<https://reviews.apache.org/r/49540/#comment205994>

    Hmm.. seems like we dont have `mesos-executor` as the first argv for a while. Just curious
that is not supposed to work correctly, right?


- Gilbert Song


On July 1, 2016, 4:24 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49540/
> -----------------------------------------------------------
> 
> (Updated July 1, 2016, 4:24 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Ian Downes, and Vinod Kone.
> 
> 
> Bugs: MESOS-5753
>     https://issues.apache.org/jira/browse/MESOS-5753
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used the argv version for command that launches the command executor.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp da643e6e50b2f313705d2f862c961291aa5d2f22 
>   src/tests/slave_tests.cpp d800cb8c10b5730a711c8354802bdff6aaca8c01 
> 
> Diff: https://reviews.apache.org/r/49540/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message