mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 49518: Initial snapshot for v1 master event stream.
Date Mon, 04 Jul 2016 03:44:33 GMT


> On July 3, 2016, 2:38 a.m., haosdent huang wrote:
> > I think we should split the test cases for `SUBSCRIBE` instead of put all of them
in `MasterAPITest.Subscribe`
> 
> Zhitao Li wrote:
>     What do you mean here? `MasterAPITest.Subscribe` is testing `SUBSCRIBE` to event
stream, ans `Snapshot` is not yet filterable, so the client would need to get it anyway. Can
you elaborate on how you think we should separate the test case?
> 
> haosdent huang wrote:
>     Oh, @zhitao. I mean whether we could have a test case `MasterAPITest.SubscribeAndSnapshot`
only test `SNAPSHOT` event. Now in `MasterAPITest.Subscribe`, we test `TASK_ADDED`, `TASK_UPDATED`
and `SNAPSHOT` events.

@haosdent, got it. I think that makes sense if/when we introduce some filter to skip snapshot
event (this has been discussed but left out in the first version), but right now we need to
capture the `Snapshot` event from client anyway, so `MasterAPITest.SubscribeAndSnapshot` would
be just be a subset of `MasterAPITest.Subscribe` code, which I don't see really worth doing.

Please let me know if your idea here is different.


- Zhitao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49518/#review140539
-----------------------------------------------------------


On July 3, 2016, 7:35 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49518/
> -----------------------------------------------------------
> 
> (Updated July 3, 2016, 7:35 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-5498
>     https://issues.apache.org/jira/browse/MESOS-5498
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Initial snapshot for v1 master event stream.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto d06258e9fd39c7eefd8ecd394e3bdfb888479b1e 
>   include/mesos/v1/master/master.proto b7cb6fdf2e4f34a11d326ac3ad3ec26525f8f343 
>   src/master/http.cpp 7b2f77b9264242f31ab62eb9db7c621a1b8aa2fe 
>   src/tests/api_tests.cpp e2d8bf591667ec9d8c609e55a424b55561892b5f 
> 
> Diff: https://reviews.apache.org/r/49518/diff/
> 
> 
> Testing
> -------
> 
> Updated test and make check.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message