mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joerg Schad <jo...@mesosphere.io>
Subject Re: Review Request 49575: Fixed `delete` usage in authorization_test.cpp.
Date Sun, 03 Jul 2016 17:48:07 GMT


> On July 3, 2016, 5:34 p.m., Vinod Kone wrote:
> > src/tests/authorization_tests.cpp, line 2342
> > <https://reviews.apache.org/r/49575/diff/1/?file=1435964#file1435964line2342>
> >
> >     hmm. why this change. these tests expect authorization creation to fail, so
`create` will not tbe `Some`?

As we use EXPECT_SOME the test will still continue and hence .get() will fail. As discussed
I updated the check to ASSERT_SOME


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49575/#review140564
-----------------------------------------------------------


On July 3, 2016, 4:47 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49575/
> -----------------------------------------------------------
> 
> (Updated July 3, 2016, 4:47 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Vinod Kone.
> 
> 
> Bugs: MESOS-5709
>     https://issues.apache.org/jira/browse/MESOS-5709
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Additionally this review fixes some minor
> formatting and typo issues.
> 
> 
> Diffs
> -----
> 
>   src/tests/authorization_tests.cpp ddd1f6f8caff7b78746f7344c83b89305e94e203 
> 
> Diff: https://reviews.apache.org/r/49575/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message