mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 49323: Added tests that combine the two ways of creating volumes.
Date Sun, 03 Jul 2016 08:03:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49323/#review140549
-----------------------------------------------------------


Ship it!




In retrospect it seems unfortunate that we split volumes tests in two files. Now it's hard
to say, where these two tests actually belong.

- Alexander Rukletsov


On July 1, 2016, 9:47 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49323/
> -----------------------------------------------------------
> 
> (Updated July 1, 2016, 9:47 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, and Michael Park.
> 
> 
> Bugs: MESOS-5698
>     https://issues.apache.org/jira/browse/MESOS-5698
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These tests check that dynamic reservations and persistent volumes can
> be created via the offer API and then removed via the HTTP endpoints,
> and vice versa.
> 
> 
> Diffs
> -----
> 
>   src/tests/persistent_volume_endpoints_tests.cpp 971a7b38d26b26c8543815e467f30cbb83ee412c

> 
> Diff: https://reviews.apache.org/r/49323/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> This test passes without any Mesos changes. i.e., it doesn't reproduce the bug by itself,
but having more test coverage for this scenario seems wise.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message