mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 49546: Added device support to Docker::run.
Date Sun, 03 Jul 2016 00:54:38 GMT


> On July 2, 2016, 8:18 p.m., Kevin Klues wrote:
> > src/docker/docker.cpp, line 677
> > <https://reviews.apache.org/r/49546/diff/1/?file=1435604#file1435604line677>
> >
> >     If all permissions are `false`, do we still want to include the ":" here? Does
this work with docker?

Thanks! Turns out docker doesn't handle this case, so I've guarded against it.


> On July 2, 2016, 8:18 p.m., Kevin Klues wrote:
> > src/tests/containerizer/docker_tests.cpp, line 661
> > <https://reviews.apache.org/r/49546/diff/1/?file=1435608#file1435608line661>
> >
> >     Now I see why this is a little weird to have `NVIDIA_GPU` here. This isn't technically
a GPU specific test -- it is valid for injecting any device into a docker container.
> >     
> >     If we wanted to make it non GPU specific. You could probe `/dev` for *some*
device on the host that's not in docker's default whitelist for devices and inject that one
instead.

Yeah, I've added a TODO to have this test not require GPUs.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49546/#review140507
-----------------------------------------------------------


On July 2, 2016, 12:55 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49546/
> -----------------------------------------------------------
> 
> (Updated July 2, 2016, 12:55 a.m.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added device support to Docker::run.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp 4343213391bb9a86e87410ce3a2c5d8447a1ab8d 
>   src/docker/docker.cpp b356848ea8f65b58102b26b38e2e753c4b665a4b 
>   src/docker/executor.cpp 2089b547408a46c9b4fa91e3ab17b88f7d2d8397 
>   src/slave/containerizer/docker.cpp 915030bdbe5a5b55acc38042ee0475074a602ee0 
>   src/tests/containerizer/docker_containerizer_tests.cpp f7b42836ceb80cdae901c4926bd702b6da36a55c

>   src/tests/containerizer/docker_tests.cpp c0ff9574633f8f72ccae9b9298f3b60bc2f3cf81 
>   src/tests/mesos.hpp 3173bf9cfc832be0aa18d745434afc45d352a269 
>   src/tests/mesos.cpp a433e5b2775f1d62b18927cf71af23ef28d6a503 
> 
> Diff: https://reviews.apache.org/r/49546/diff/
> 
> 
> Testing
> -------
> 
> Added a test.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message