mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 49567: Cleaned up some logic in stout/elf.hpp.
Date Sat, 02 Jul 2016 23:55:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49567/#review140524
-----------------------------------------------------------


Ship it!




Let's split the bug fix into a separate patch. Also let's include a description that mentions
that this logic was working around the ELFIO bug that we now fix via a .patch file.

- Benjamin Mahler


On July 2, 2016, 11:10 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49567/
> -----------------------------------------------------------
> 
> (Updated July 2, 2016, 11:10 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Cleaned up some logic in stout/elf.hpp.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/elf.hpp 94b1de97b14d10c4796933e2aa395c195c94ee10 
> 
> Diff: https://reviews.apache.org/r/49567/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message