mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 49414: Added Executor PID in /containers endpoint. Also Added Test Cases.
Date Sat, 02 Jul 2016 23:40:58 GMT


> On July 2, 2016, 5:46 a.m., Jie Yu wrote:
> > src/tests/containerizer/mesos_containerizer_tests.cpp, line 580
> > <https://reviews.apache.org/r/49414/diff/1/?file=1433812#file1433812line580>
> >
> >     Please use UUID::random here.
> 
> Haris Choudhary wrote:
>     I've made the changes. But consider if both UUID's were the same as a result of random,
the test would fail.
>     However I think its super rare for both to be generated as the same.

UUID stands for universal unique id. Many components in Mesos will break if the uniqueness
assumption is broken. I won't be too worried.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49414/#review140479
-----------------------------------------------------------


On July 2, 2016, 9:50 p.m., Haris Choudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49414/
> -----------------------------------------------------------
> 
> (Updated July 2, 2016, 9:50 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5737
>     https://issues.apache.org/jira/browse/MESOS-5737
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added Executor PID in /containers endpoint. Also Added Test Cases.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 5b15a89bbac0b33c77e305c5b188823f2704a653 
>   include/mesos/v1/mesos.proto a1435278e81c8f3179d94cd9d2c3dd8c0ba82d35 
>   src/slave/containerizer/mesos/containerizer.cpp a96b382f22886362a1159e1166dfe041072985ba

>   src/slave/containerizer/mesos/launcher.hpp 05320f462653c31fc2f093d6c67e2182e9c794fa

>   src/slave/containerizer/mesos/launcher.cpp ff675262af8947b89f8099828665e5e5d86491d8

>   src/slave/containerizer/mesos/linux_launcher.hpp 89bb2958a41dffe4ade9c2492b9a7412f90a432d

>   src/slave/containerizer/mesos/linux_launcher.cpp 5028854fa003615f158120e030866b7ec4402b66

>   src/tests/containerizer/launcher.hpp c352634c4766d289706c7cc738677619d7d02ccd 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 6c14f6e20b4d14d5ed095670673571739101b0e4

> 
> Diff: https://reviews.apache.org/r/49414/diff/
> 
> 
> Testing
> -------
> 
> make and make check.
> 
> 
> Thanks,
> 
> Haris Choudhary
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message