mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 49564: Added `get_abi_version()` to the ELF parsing abstraction.
Date Sat, 02 Jul 2016 22:39:13 GMT


> On July 2, 2016, 10:22 p.m., Benjamin Mahler wrote:
> > 3rdparty/stout/include/stout/elf.hpp, line 84
> > <https://reviews.apache.org/r/49564/diff/1/?file=1435702#file1435702line84>
> >
> >     Cleanups in a separate patch next time?

Whoops! I must have squashed this into the wrong commit.  I meant to make this part of the
original libelf --> ELFIO transition.


> On July 2, 2016, 10:22 p.m., Benjamin Mahler wrote:
> > 3rdparty/stout/include/stout/elf.hpp, line 159
> > <https://reviews.apache.org/r/49564/diff/1/?file=1435702#file1435702line159>
> >
> >     "only" suggests that there are more than 1 entries, but there can be 0 here
according to the condition being checked

There should be 1 and only one (if the section existst at all).


> On July 2, 2016, 10:22 p.m., Benjamin Mahler wrote:
> > 3rdparty/stout/include/stout/elf.hpp, lines 177-184
> > <https://reviews.apache.org/r/49564/diff/1/?file=1435702#file1435702line177>
> >
> >     Do we need to mention the patch here?

This comment can be removed. I put it in when I was messing with the workaround.  The check
should actually jsut be "name == GNU" now.


> On July 2, 2016, 10:22 p.m., Benjamin Mahler wrote:
> > src/tests/ldcache_tests.cpp, lines 66-69
> > <https://reviews.apache.org/r/49564/diff/1/?file=1435703#file1435703line66>
> >
> >     This needs to be in a separate commit because of stout/libprocess/mesos split.

Yeah. Weird that it let me commit it then (usually the linter catches things like this).


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49564/#review140516
-----------------------------------------------------------


On July 2, 2016, 7:38 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49564/
> -----------------------------------------------------------
> 
> (Updated July 2, 2016, 7:38 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5769
>     https://issues.apache.org/jira/browse/MESOS-5769
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This function returns the ABI version of the ELF file by parsing the
> contents of its `.note.ABI-tag` section. This section is Linux
> specific and adheres to the format described in the links below.
> 
> https://refspecs.linuxfoundation.org/LSB_1.2.0/gLSB/noteabitag.html
> http://flint.cs.yale.edu/cs422/doc/ELF_Format.pdf
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/elf.hpp 5382acc1c12901ce8d8256f6010f48579020fbca 
>   src/tests/ldcache_tests.cpp b387a8b763d241075392f65256d9b39429909d8b 
> 
> Diff: https://reviews.apache.org/r/49564/diff/
> 
> 
> Testing
> -------
> 
> `GTEST_FILTER="*Ldcache*" make -j check`
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message