mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 49563: Reimplemented ldcache_test.cpp using the new ELF abstraction in stout.
Date Sat, 02 Jul 2016 21:51:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49563/#review140515
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Mahler


On July 2, 2016, 7:35 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49563/
> -----------------------------------------------------------
> 
> (Updated July 2, 2016, 7:35 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5768
>     https://issues.apache.org/jira/browse/MESOS-5768
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We also reenabled this test to run as part of the standard Linux test
> suite. It had been disabled due to its dependence on the external
> libelf library. Now that we bundle ELFIO instead of relying on this
> external dependence, we can always have it enabled now.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 52d63f26e0455ef31411e964e497a509d96aaf4a 
>   src/tests/ldcache_tests.cpp b387a8b763d241075392f65256d9b39429909d8b 
> 
> Diff: https://reviews.apache.org/r/49563/diff/
> 
> 
> Testing
> -------
> 
> `GTEST_FILTER="LdcacheTest*" make -j check`
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message