mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 49566: Integrated the 'NvidiaVolume' component into 'NvidiaComponents'.
Date Sat, 02 Jul 2016 20:08:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49566/#review140506
-----------------------------------------------------------



Bad patch!

Reviews applied: [49566, 49565, 49564, 49563, 49562, 49561, 49560, 49559, 49558, 46220, 45970,
46053, 45969]

Failed command: ./support/apply-review.sh -n -r 46220

Error:
2016-07-02 20:08:11 URL:https://reviews.apache.org/r/46220/diff/raw/ [21952/21952] -> "46220.patch"
[1]
error: patch failed: docs/home.md:42
error: docs/home.md: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/14087/console

- Mesos ReviewBot


On July 2, 2016, 7:43 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49566/
> -----------------------------------------------------------
> 
> (Updated July 2, 2016, 7:43 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Yubo Li, and Vikrama Ditya.
> 
> 
> Bugs: MESOS-5401
>     https://issues.apache.org/jira/browse/MESOS-5401
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This makes it so that the 'NvidiaVolume' component can be shared
> across containerizers in the same way that the 'NvidiaGpuAllocator' is
> currently being shared.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/containerizer.cpp a436a5d6e367bfd310a003193c9d3770c3fcbac9

>   src/slave/containerizer/mesos/isolators/gpu/components.hpp 39c6126f5a5023e59b1bd2d90f1aaa47b09d6b28

> 
> Diff: https://reviews.apache.org/r/49566/diff/
> 
> 
> Testing
> -------
> 
> `GTEST_FILTER="*NVIDIA_GPU_Volume*" make -j check`
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message