mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 49544: Made stout::Path default constructible / assignable / copyable.
Date Sat, 02 Jul 2016 19:56:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49544/#review140503
-----------------------------------------------------------




3rdparty/stout/include/stout/path.hpp (lines 255 - 261)
<https://reviews.apache.org/r/49544/#comment205902>

    Do we really need this function? It looks like just casting it to a string would be enough
to turn it into a string?



3rdparty/stout/include/stout/path.hpp (line 267)
<https://reviews.apache.org/r/49544/#comment205903>

    If e just cast it to a string, this should be sufficeint.



3rdparty/stout/include/stout/path.hpp (line 279)
<https://reviews.apache.org/r/49544/#comment205904>

    ditto



3rdparty/stout/include/stout/path.hpp (line 305)
<https://reviews.apache.org/r/49544/#comment205905>

    ditto


- Kevin Klues


On July 2, 2016, 12:46 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49544/
> -----------------------------------------------------------
> 
> (Updated July 2, 2016, 12:46 a.m.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This makes Path closer to boost's path, and more convenient to work with (e.g. as map
values, struct members, etc).
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/path.hpp 0ca13c6a1aebcb980c29dd33414bfa50c4b8bf81 
> 
> Diff: https://reviews.apache.org/r/49544/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message