mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Review Request 49565: Added a new 'NvidiaVolume' component.
Date Sat, 02 Jul 2016 19:41:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49565/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler, Yubo Li, and Vikrama Ditya.


Bugs: MESOS-5401
    https://issues.apache.org/jira/browse/MESOS-5401


Repository: mesos


Description
-------

This component is responsible for building up a consolidated volume of
binaries / libraries from the user-space portion of the Nvidia GPU
drivers so that it can be injected into a container as a single
volume. Its core functionality mimics that of the
`nvidia-docker-plugin`: https://github.com/NVIDIA/nvidia-docker/

We currently only implement the 'create()' function which is
responsible for building up the volume itself. In a subsequent commit
we will add support for reading a Docker ImageManifest and deciding if
we should inject the volume into the docker container or not.


Diffs
-----

  src/CMakeLists.txt 09dd0e0dd2f25fb71db5051d5f5a797a981c2e59 
  src/Makefile.am 52d63f26e0455ef31411e964e497a509d96aaf4a 
  src/slave/containerizer/mesos/isolators/gpu/nvidia.hpp 01cdab2f87d3ac823b8647c084c481593b6fa07f

  src/slave/containerizer/mesos/isolators/gpu/volume.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/gpu/volume.cpp PRE-CREATION 
  src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 6770f05455f19d12b7984162f93a8b458951926f


Diff: https://reviews.apache.org/r/49565/diff/


Testing
-------

`GTEST_FILTER="*NVIDIA_GPU_Volume*" make -j check`


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message