mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Review Request 49564: Added `get_abi_version()` to the ELF parsing abstraction.
Date Sat, 02 Jul 2016 19:38:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49564/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-5769
    https://issues.apache.org/jira/browse/MESOS-5769


Repository: mesos


Description
-------

This function returns the ABI version of the ELF file by parsing the
contents of its `.note.ABI-tag` section. This section is Linux
specific and adheres to the format described in the links below.

https://refspecs.linuxfoundation.org/LSB_1.2.0/gLSB/noteabitag.html
http://flint.cs.yale.edu/cs422/doc/ELF_Format.pdf


Diffs
-----

  3rdparty/stout/include/stout/elf.hpp 5382acc1c12901ce8d8256f6010f48579020fbca 
  src/tests/ldcache_tests.cpp b387a8b763d241075392f65256d9b39429909d8b 

Diff: https://reviews.apache.org/r/49564/diff/


Testing
-------

`GTEST_FILTER="*Ldcache*" make -j check`


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message