mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Review Request 49562: Reimplemented the stout ELF abstraction in terms of ELFIO.
Date Sat, 02 Jul 2016 19:31:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49562/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-5768
    https://issues.apache.org/jira/browse/MESOS-5768


Repository: mesos


Description
-------

As part of this, we updated the API to include functions written in
snake_case (as is standard for stout). We also removed the 'close()'
call, as the new ELFIO library doesn't require it.


Diffs
-----

  3rdparty/stout/include/stout/elf.hpp 5382acc1c12901ce8d8256f6010f48579020fbca 

Diff: https://reviews.apache.org/r/49562/diff/


Testing
-------

Tests coming in subsequent patch with updates to `ldcache_tests.cpp`


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message