mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Review Request 49561: Added ELFIO as bundled dependency in stout.
Date Sat, 02 Jul 2016 19:29:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49561/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-5767
    https://issues.apache.org/jira/browse/MESOS-5767


Repository: mesos


Description
-------

Added ELFIO as bundled dependency in stout.


Diffs
-----

  3rdparty/stout/Makefile.am eeaca480872b97d60891376b8c21fda7b65a6f00 
  3rdparty/stout/cmake/StoutConfigure.cmake e4e3217a6f6053d3555d4602f7173c6fe94daeda 
  3rdparty/stout/configure.ac ca6f041b5ad5c92e683500f7b34a521fefa318f4 

Diff: https://reviews.apache.org/r/49561/diff/


Testing
-------

Made sure `elfio-3.1` appears in `/build` after running `../configure`, `make`.
Made sure `elfio` appears in `/include` of installation folder after `make install`.

This second one is necessary because `stout` relies on `elfio` in order to function (similar
to how we've done with `picojson.h` in the past).


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message