mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 49348: Added implementation to Appc Runtime Isolator.
Date Sat, 02 Jul 2016 10:28:15 GMT


> On 七月 2, 2016, 10:19 a.m., Guangya Liu wrote:
> > src/slave/containerizer/mesos/isolators/appc/runtime.cpp, lines 202-205
> > <https://reviews.apache.org/r/49348/diff/5/?file=1435404#file1435404line202>
> >
> >     1. s/Exec/'Exec'
> >     2. Add period to the end of each comment.
> >     
> >     It would be great to add more comments to the end for the commnets by refering
to the row of the table.
> >     
> >     Such as:
> >     // 1. If 'shell' is false,  and 'value' is not set, use Exec from the image.
(row 1-2)
> >     // 2. If 'shell' is false and 'value' is set, ignore Exec from the image. (row
3-4)
> >     // 3. If 'shell' is true and 'value' is not set, return error. (row 5-6)
> >     // 4. If 'shell' is true and 'value' is set, ignore Exec from the image. (row
7-8)

The period should be appended to the end.

// 1. If 'shell' is false,  and 'value' is not set, use Exec from the image (row 1-2).
// 2. If 'shell' is false and 'value' is set, ignore Exec from the image (row 3-4).
// 3. If 'shell' is true and 'value' is not set, return error (row 5-6).
// 4. If 'shell' is true and 'value' is set, ignore Exec from the image (row 7-8).


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49348/#review140475
-----------------------------------------------------------


On 七月 1, 2016, 9:44 p.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49348/
> -----------------------------------------------------------
> 
> (Updated 七月 1, 2016, 9:44 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added implementation to Appc Runtime Isolator.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/appc/runtime.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49348/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message