mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 49414: Added Executor PID in /containers endpoint. Also Added Test Cases.
Date Sat, 02 Jul 2016 05:46:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49414/#review140479
-----------------------------------------------------------




src/slave/containerizer/mesos/launcher.hpp (line 78)
<https://reviews.apache.org/r/49414/#comment205857>

    Add a new line above.



src/slave/containerizer/mesos/launcher.hpp (line 81)
<https://reviews.apache.org/r/49414/#comment205858>

    indentation for parameters should be 4



src/slave/containerizer/mesos/launcher.hpp (line 115)
<https://reviews.apache.org/r/49414/#comment205859>

    Ditto.



src/slave/containerizer/mesos/linux_launcher.hpp (line 55)
<https://reviews.apache.org/r/49414/#comment205860>

    Ditto.



src/slave/containerizer/mesos/linux_launcher.cpp (line 367)
<https://reviews.apache.org/r/49414/#comment205861>

    2 lines apart between top level functions.



src/tests/containerizer/mesos_containerizer_tests.cpp (line 458)
<https://reviews.apache.org/r/49414/#comment205862>

    Please move this right above `TEST_F(MesosLauncherStatusTest ...`
    
    And please move all the stuff you just added to the end of this file.



src/tests/containerizer/mesos_containerizer_tests.cpp (line 566)
<https://reviews.apache.org/r/49414/#comment205863>

    2 lines apart please.



src/tests/containerizer/mesos_containerizer_tests.cpp (line 580)
<https://reviews.apache.org/r/49414/#comment205864>

    Please use UUID::random here.



src/tests/containerizer/mesos_containerizer_tests.cpp (line 582)
<https://reviews.apache.org/r/49414/#comment205865>

    Ditto on using UUID::random



src/tests/containerizer/mesos_containerizer_tests.cpp (lines 585 - 593)
<https://reviews.apache.org/r/49414/#comment205871>

    INdentation here should be 4.



src/tests/containerizer/mesos_containerizer_tests.cpp (lines 591 - 593)
<https://reviews.apache.org/r/49414/#comment205866>

    NO need for those default variables.



src/tests/containerizer/mesos_containerizer_tests.cpp (line 599)
<https://reviews.apache.org/r/49414/#comment205868>

    Please use AWAIT_READY(validStatus) here



src/tests/containerizer/mesos_containerizer_tests.cpp (line 601)
<https://reviews.apache.org/r/49414/#comment205867>

    you can use `validStatus->executor_id`



src/tests/containerizer/mesos_containerizer_tests.cpp (line 603)
<https://reviews.apache.org/r/49414/#comment205869>

    No need for back slash in the end



src/tests/containerizer/mesos_containerizer_tests.cpp (line 604)
<https://reviews.apache.org/r/49414/#comment205870>

    Indentation here should be 2. See style guide



src/tests/containerizer/mesos_containerizer_tests.cpp (line 610)
<https://reviews.apache.org/r/49414/#comment205872>

    2 lines apart, please.


- Jie Yu


On June 30, 2016, 12:51 a.m., Haris Choudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49414/
> -----------------------------------------------------------
> 
> (Updated June 30, 2016, 12:51 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5737
>     https://issues.apache.org/jira/browse/MESOS-5737
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added Executor PID in /containers endpoint. Also Added Test Cases.
> 
> In order to greatly simplify the implementation for the Mesos CLI's container plugin,
we need the executor PID (Process ID) to be exposed in the /containers endpoint. [Mesos CLI
Epic](https://issues.apache.org/jira/browse/MESOS-5676)
> This change will introduce the pid for an executor if it was launched by the mesos containerizer
in the /containers endpoint of an agent.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 5b15a89bbac0b33c77e305c5b188823f2704a653 
>   include/mesos/v1/mesos.proto a1435278e81c8f3179d94cd9d2c3dd8c0ba82d35 
>   src/slave/containerizer/mesos/containerizer.cpp a96b382f22886362a1159e1166dfe041072985ba

>   src/slave/containerizer/mesos/launcher.hpp 05320f462653c31fc2f093d6c67e2182e9c794fa

>   src/slave/containerizer/mesos/launcher.cpp ff675262af8947b89f8099828665e5e5d86491d8

>   src/slave/containerizer/mesos/linux_launcher.hpp 89bb2958a41dffe4ade9c2492b9a7412f90a432d

>   src/slave/containerizer/mesos/linux_launcher.cpp 5028854fa003615f158120e030866b7ec4402b66

>   src/tests/containerizer/launcher.hpp c352634c4766d289706c7cc738677619d7d02ccd 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 6c14f6e20b4d14d5ed095670673571739101b0e4

> 
> Diff: https://reviews.apache.org/r/49414/diff/
> 
> 
> Testing
> -------
> 
> make and make check.
> 
> 
> Thanks,
> 
> Haris Choudhary
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message