mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 49543: Fix ProcessRemoteLinkTests that try to emulate 'stale' sockets.
Date Sat, 02 Jul 2016 03:12:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49543/#review140473
-----------------------------------------------------------



Patch looks great!

Reviews applied: [49543]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On July 1, 2016, 11:53 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49543/
> -----------------------------------------------------------
> 
> (Updated July 1, 2016, 11:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-5759
>     https://issues.apache.org/jira/browse/MESOS-5759
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The ProcessRemoteLinkTests `RemoteUseStaleLink` and 
> `RemoteStaleLinkRelink` were failing because the `test-linkee` was
> closing sockets shortly after the test `::shutdown` the link.  This 
> is the expected behavior of libprocess.
> 
> Rewrites the `test-linkee` to keep all sockets open, regardless of the
> state of the connection.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/test_linkee.cpp 7ba0f4833a5163d2323e1477509fd2fbacc23690

> 
> Diff: https://reviews.apache.org/r/49543/diff/
> 
> 
> Testing
> -------
> 
> make check (CentOS 7)
> 
> 3rdparty/libprocess/libprocess-tests --gtest_filter="ProcessRemoteLinkTest*" --gtest_break_on_failure
--gtest_repeat=10000
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message