mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Review Request 49542: Explicitly passed in launcher dir to command executor.
Date Fri, 01 Jul 2016 23:53:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49542/
-----------------------------------------------------------

Review request for mesos, Gilbert Song, Joris Van Remoortere, and Timothy Chen.


Bugs: MESOS-5753
    https://issues.apache.org/jira/browse/MESOS-5753


Repository: mesos


Description
-------

Relying on dirname is not quite reliable, especially in tests where
launchable scripts are under 'build/src', but actual binaries are
under 'build/src/.libs'. This patch passed in launcher_dir explicitly
through executor flags.


Diffs
-----

  src/launcher/executor.cpp bb88a4570d183d22dff65f6e220d566c0924001a 
  src/slave/slave.cpp da643e6e50b2f313705d2f862c961291aa5d2f22 
  src/tests/health_check_tests.cpp 1c4a554ab07731963a4a38e3ae40b0323bf317bb 
  src/tests/slave_tests.cpp d800cb8c10b5730a711c8354802bdff6aaca8c01 

Diff: https://reviews.apache.org/r/49542/diff/


Testing
-------

make check


Thanks,

Jie Yu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message