mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 49509: Revised protobuf definition of GetState response.
Date Fri, 01 Jul 2016 23:44:06 GMT


> On July 1, 2016, 7:22 p.m., Vinod Kone wrote:
> > include/mesos/master/master.proto, lines 273-274
> > <https://reviews.apache.org/r/49509/diff/1/?file=1435004#file1435004line273>
> >
> >     move this to GetLeadingMaster.

Removed. If we want this in the other call, let's do it in a separate patch.


> On July 1, 2016, 7:22 p.m., Vinod Kone wrote:
> > include/mesos/v1/master/master.proto, lines 274-275
> > <https://reviews.apache.org/r/49509/diff/1/?file=1435005#file1435005line274>
> >
> >     ditto. move this to GetLeadingMaster

Ditto.


- Zhitao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49509/#review140409
-----------------------------------------------------------


On July 1, 2016, 11:43 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49509/
> -----------------------------------------------------------
> 
> (Updated July 1, 2016, 11:43 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-5489
>     https://issues.apache.org/jira/browse/MESOS-5489
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Revised protobuf definition of GetState response.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto d06258e9fd39c7eefd8ecd394e3bdfb888479b1e 
>   include/mesos/v1/master/master.proto b7cb6fdf2e4f34a11d326ac3ad3ec26525f8f343 
> 
> Diff: https://reviews.apache.org/r/49509/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message