mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 49389: Refactored HealthCheck from a binary to be a library.
Date Fri, 01 Jul 2016 22:24:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49389/#review140444
-----------------------------------------------------------


Fix it, then Ship it!





src/health-check/health_checker.hpp (line 64)
<https://reviews.apache.org/r/49389/#comment205830>

    Let's kill this and use explicit includes.



src/launcher/executor.cpp (lines 430 - 431)
<https://reviews.apache.org/r/49389/#comment205831>

    Hum, if `_check.isError()`, `checker->healthCheck()` below will abort. you should put
`checker->healthCheck()` in else block


- Jie Yu


On July 1, 2016, 9:54 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49389/
> -----------------------------------------------------------
> 
> (Updated July 1, 2016, 9:54 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, haosdent huang, Artem Harutyunyan,
Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-5727
>     https://issues.apache.org/jira/browse/MESOS-5727
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refactored HealthCheck from a binary to be a library.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 996d9e655b9d4343c07663fe840e94727cd792fe 
>   src/Makefile.am 72f8a995f0a6373c0108900ff40395f698aa678e 
>   src/health-check/health_checker.hpp PRE-CREATION 
>   src/health-check/health_checker.cpp PRE-CREATION 
>   src/health-check/main.cpp 4cc9dde8927acd4594477476f1b1bdc43963d789 
>   src/launcher/executor.cpp bb88a4570d183d22dff65f6e220d566c0924001a 
> 
> Diff: https://reviews.apache.org/r/49389/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message