mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <>
Subject Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.
Date Fri, 01 Jul 2016 21:41:22 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 1, 2016, 9:41 p.m.)

Review request for mesos, Neil Conway and Jiang Yan Xu.


Added a unit test to check for failed slave recovery if the target checkpoint contains a volume
to be CREATEd which has non-empty contents.

Bugs: MESOS-5448

Repository: mesos


Root of a MOUNT disk is not deleted on volume DELETE. When we do a
CREATE on a persistent volume and the root directory exists (which
can happen for MOUNT disks), we allow the operation only if the
contents within the root directory is empty. If not, we do not update
the checkpoint with this volume and exit, so as to cleanup when the
slave restarts and handles the CheckpointResourcesMessage.

Diffs (updated)

  docs/ 20b99e0e57360ad43804201b27e593d7ed48ce2c 
  src/slave/slave.cpp da643e6e50b2f313705d2f862c961291aa5d2f22 
  src/tests/persistent_volume_tests.cpp 5125a8da44759d1235fddac26e9eb5436c3d037b 



All tests passed.


Anindya Sinha

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message