mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhishek Dasgupta <a10gu...@linux.vnet.ibm.com>
Subject Re: Review Request 49446: Implemented LIST_FILES Call in v1 master API.
Date Fri, 01 Jul 2016 20:20:19 GMT


> On June 30, 2016, 10:21 p.m., Anand Mazumdar wrote:
> > src/master/http.cpp, line 2813
> > <https://reviews.apache.org/r/49446/diff/1/?file=1434166#file1434166line2813>
> >
> >     Can we have an explicit defensive check here to ensure `result` does not have
error set?
> >     
> >     Also, applies to the prior review for `/files/browse`.

Didn't quite get it. We are already checking result.isError() .


- Abhishek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49446/#review140242
-----------------------------------------------------------


On June 30, 2016, 2:06 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49446/
> -----------------------------------------------------------
> 
> (Updated June 30, 2016, 2:06 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-5487
>     https://issues.apache.org/jira/browse/MESOS-5487
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented LIST_FILES Call in v1 master API.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto 2e5d6eeb3a960e4f41c382d65321f18bb05ed6be 
>   include/mesos/v1/master/master.proto 93157d57dcc53b54fed2ebbc4772c689ddba2119 
>   src/master/http.cpp e5acdb8e0bbcd7a2b7e8a8bc7f4bbeaae2c4fea1 
>   src/master/master.hpp e2ab2110fe5a287ab16ac9ef4222fed633e02ebe 
> 
> Diff: https://reviews.apache.org/r/49446/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message