mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhishek Dasgupta <a10gu...@linux.vnet.ibm.com>
Subject Re: Review Request 49445: Updated FilesProcess to support List_Files Call in Operator API v1.
Date Fri, 01 Jul 2016 20:03:48 GMT


> On June 30, 2016, 9:45 p.m., Anand Mazumdar wrote:
> > src/files/files.cpp, lines 104-106
> > <https://reviews.apache.org/r/49445/diff/1/?file=1434162#file1434162line104>
> >
> >     See my earlier comments in the header file about this function and then modify
this.

If changed to browse(), obviously this compliler error is coming :

../src/files/files.cpp:223:71: error: no matching function for call to ‘bind(<unresolved
overloaded function type>, mesos::internal::FilesProcess*, const std::_Placeholder<1>&,
None)’
           lambda::bind(&FilesProcess::browse, this, lambda::_1, None()));


- Abhishek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49445/#review140238
-----------------------------------------------------------


On June 30, 2016, 2:06 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49445/
> -----------------------------------------------------------
> 
> (Updated June 30, 2016, 2:06 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-5487
>     https://issues.apache.org/jira/browse/MESOS-5487
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated FilesProcess to support List_Files Call in Operator API v1.
> 
> 
> Diffs
> -----
> 
>   src/files/files.hpp b767d5bc5bee16e3bd98199773a6bc7d30c1c32d 
>   src/files/files.cpp a5a1b86e14f63e5e3834a2900270252fbe16f586 
>   src/tests/files_tests.cpp 31337e280c6224a8c949c8868a53e5a785b4573f 
> 
> Diff: https://reviews.apache.org/r/49445/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message