mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 49518: Initial snapshot for v1 master event stream.
Date Fri, 01 Jul 2016 19:41:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49518/#review140416
-----------------------------------------------------------




include/mesos/master/master.proto (line 446)
<https://reviews.apache.org/r/49518/#comment205813>

    // Snapshot of the entire cluster state. This is the first event
    // that is sent after a client is subscribed. Further updates to
    // the cluster state are sent as separate events on the stream.



include/mesos/v1/master/master.proto (lines 447 - 449)
<https://reviews.apache.org/r/49518/#comment205814>

    see above.



src/master/http.cpp (line 595)
<https://reviews.apache.org/r/49518/#comment205815>

    just capture `http`?



src/master/http.cpp (lines 597 - 598)
<https://reviews.apache.org/r/49518/#comment205816>

    what do you mean by "before subscribe"?
    
    // Send snapshot of the current state before any other events.


- Vinod Kone


On July 1, 2016, 4:12 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49518/
> -----------------------------------------------------------
> 
> (Updated July 1, 2016, 4:12 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-5498
>     https://issues.apache.org/jira/browse/MESOS-5498
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Initial snapshot for v1 master event stream.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto e34414ba9f4b350254396ca1d6391f7cc5ef451f 
>   include/mesos/v1/master/master.proto f6155dfacfbd98efaf72b337b73cc950c0f3b7c3 
>   src/master/http.cpp 528f01f2e00ddbd15da1cc4fca27b5347c9fc798 
>   src/tests/api_tests.cpp a7f075172f870bcd3ac7fb9c7a69b70ac5cb73c5 
> 
> Diff: https://reviews.apache.org/r/49518/diff/
> 
> 
> Testing
> -------
> 
> Updated test and make check.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message