mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 49517: Implement GetState V1 master API.
Date Fri, 01 Jul 2016 19:31:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49517/#review140412
-----------------------------------------------------------




src/master/http.cpp (line 1428)
<https://reviews.apache.org/r/49517/#comment205805>

    fix this in the previous review.



src/master/http.cpp (lines 1536 - 1537)
<https://reviews.apache.org/r/49517/#comment205806>

    ditto. see earlier review for comments.



src/master/http.cpp (lines 1565 - 1569)
<https://reviews.apache.org/r/49517/#comment205808>

    this should be moved to GetLeadingMaster



src/master/http.cpp (line 1571)
<https://reviews.apache.org/r/49517/#comment205807>

    s/instead/instead of/



src/tests/api_tests.cpp (lines 430 - 433)
<https://reviews.apache.org/r/49517/#comment205809>

    mvoe this to #465



src/tests/api_tests.cpp (lines 533 - 534)
<https://reviews.apache.org/r/49517/#comment205810>

    move this to #549.



src/tests/api_tests.cpp (line 537)
<https://reviews.apache.org/r/49517/#comment205811>

    copy paste error? update the comment.



src/tests/api_tests.cpp (line 546)
<https://reviews.apache.org/r/49517/#comment205812>

    a task goes to completed after the ACK for terminal state is processed by the master.
you need to setup an expectation on StatusUpdateAcknowledgement message to guarantee that.
See `GetTasks` test for an example.


- Vinod Kone


On July 1, 2016, 4:09 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49517/
> -----------------------------------------------------------
> 
> (Updated July 1, 2016, 4:09 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-5489
>     https://issues.apache.org/jira/browse/MESOS-5489
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The help function will also be used for snapshot of
> event stream.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 528f01f2e00ddbd15da1cc4fca27b5347c9fc798 
>   src/master/master.hpp 7388a3e7f3a0c9f0a2a286a8c8107210971b654a 
>   src/tests/api_tests.cpp a7f075172f870bcd3ac7fb9c7a69b70ac5cb73c5 
> 
> Diff: https://reviews.apache.org/r/49517/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message