mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 49488: Refactor master::Http::getAgents into helper function.
Date Fri, 01 Jul 2016 19:18:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49488/#review140404
-----------------------------------------------------------




src/master/http.cpp (lines 1964 - 1967)
<https://reviews.apache.org/r/49488/#comment205794>

    ditto. see comments in earlier review.



src/master/http.cpp (line 1966)
<https://reviews.apache.org/r/49488/#comment205796>

    s/getAgentsResp/getAgents/



src/master/http.cpp (line 1983)
<https://reviews.apache.org/r/49488/#comment205795>

    space after "="


- Vinod Kone


On July 1, 2016, 2:47 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49488/
> -----------------------------------------------------------
> 
> (Updated July 1, 2016, 2:47 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The new helper function will be reused by both `GET_AGENTS`
> and `GET_STATE` calls.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 528f01f2e00ddbd15da1cc4fca27b5347c9fc798 
>   src/master/master.hpp 7388a3e7f3a0c9f0a2a286a8c8107210971b654a 
> 
> Diff: https://reviews.apache.org/r/49488/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message