mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 49480: Added installing NVML headers with --enable-install-module-dependencies.
Date Fri, 01 Jul 2016 16:08:35 GMT


> On July 1, 2016, 1:29 p.m., Kapil Arya wrote:
> > 3rdparty/Makefile.am, line 305
> > <https://reviews.apache.org/r/49480/diff/2/?file=1434580#file1434580line305>
> >
> >     Will `NVML` install any additional non-include files? If so, we need to fix
`DESTDIR`.

No. Here are the contents of the Makefile:

```
prefix=/usr/local
includedir=$(prefix)/include

install:
    install -d $(DESTDIR)$(includedir)/nvidia/gdk
    install -p -m 0644 nvidia/gdk/nvml.h $(DESTDIR)$(includedir)/nvidia/gdk

uninstall:
    rm -rf $(DESTDIR)$(includedir)/nvidia

.PHONY: install uninstall
```


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49480/#review140343
-----------------------------------------------------------


On June 30, 2016, 11:54 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49480/
> -----------------------------------------------------------
> 
> (Updated June 30, 2016, 11:54 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Kapil Arya, and Till Toenshoff.
> 
> 
> Bugs: MESOS-5755
>     https://issues.apache.org/jira/browse/MESOS-5755
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added installing NVML headers with --enable-install-module-dependencies.
> 
> 
> Diffs
> -----
> 
>   3rdparty/Makefile.am 2b24387 
>   3rdparty/nvml-352.79.tar.gz 04eee42c306344369b27ffe5f884663e634960b1 
> 
> Diff: https://reviews.apache.org/r/49480/diff/
> 
> 
> Testing
> -------
> 
> ../configure --enable-install-module-dependencies --prefix=$HOME/mesos-install
> make install
> find $HOME/mesos-install -name nvml.h
>   --> $HOME/mesos-install/lib/mesos/3rdparty/include/nvidia/gdk/nvml.h
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message