mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 49377: Fixed allocator to update total resources in quota sorter.
Date Fri, 01 Jul 2016 09:47:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49377/
-----------------------------------------------------------

(Updated July 1, 2016, 9:47 a.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, and Michael Park.


Changes
-------

Rebase.


Bugs: MESOS-5698
    https://issues.apache.org/jira/browse/MESOS-5698


Repository: mesos


Description
-------

Each DRFSorter tracks the total resources in the cluster. This means
that each sorter must be updated when the resources in the cluster have
changed, e.g., due to the creation of a dynamic reservation or a
persistent volume. In the previous implementation, the quota role sorter
was not updated for non-quota roles when a reservation or persistent
volume was created by a framework. This resulted in inconsistency
between the total resources in the allocator and the quota role sorter.

This could cause several problems. First, removing a slave from the
cluster would leak resources in the quota role sorter. Second, certain
interleavings of slave removals and reserve/unreserve operations by
frameworks and via HTTP endpoints could lead to CHECK failures.


Diffs (updated)
-----

  src/master/allocator/mesos/hierarchical.cpp 38381237fa6ceb3f21fd0d4b07d7c3787f0129df 
  src/master/allocator/sorter/drf/sorter.cpp 967290d4d1100208900b4b724422c3218abc23cb 
  src/tests/persistent_volume_endpoints_tests.cpp 971a7b38d26b26c8543815e467f30cbb83ee412c


Diff: https://reviews.apache.org/r/49377/diff/


Testing
-------

make check on OSX and recent Arch Linux.


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message