mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 49242: Add ReadFile protobuf message.
Date Fri, 01 Jul 2016 03:51:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49242/#review140296
-----------------------------------------------------------




include/mesos/agent/agent.proto (lines 80 - 82)
<https://reviews.apache.org/r/49242/#comment205675>

    We should be changing these (`offset`/`length`) to be their correct data types and not
being `string` in a separate patch. Also, we should document the call/fields for posterity.
    
    Ditto for the master proto.



include/mesos/agent/agent.proto (line 147)
<https://reviews.apache.org/r/49242/#comment205676>

    Can we write a short description about this message similar to what we have done for other
messages?
    
    Also, can you document both the fields in the response for posterity?
    
    Ditto for the master proto.



include/mesos/agent/agent.proto (line 149)
<https://reviews.apache.org/r/49242/#comment205674>

    Why did you change it from being `repeated bytes`?
    
    Ditto for the master proto.


- Anand Mazumdar


On June 30, 2016, 6:57 a.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49242/
> -----------------------------------------------------------
> 
> (Updated June 30, 2016, 6:57 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5515
>     https://issues.apache.org/jira/browse/mesos-5515
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add ReadFile message in the Response message of master.proto
> , v1/master.proto, agent.proto, v1/agent.proto.
> 
> 
> Diffs
> -----
> 
>   include/mesos/agent/agent.proto 538d12f71df1943f91bafb99650625aa910affaa 
>   include/mesos/master/master.proto 2e5d6eeb3a960e4f41c382d65321f18bb05ed6be 
>   include/mesos/v1/agent/agent.proto 48f15173fe62b9ce7f648f6b54d74ec62f797c55 
>   include/mesos/v1/master/master.proto 93157d57dcc53b54fed2ebbc4772c689ddba2119 
> 
> Diff: https://reviews.apache.org/r/49242/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message